Bump min PyTorch version#855
Merged
Merged
Conversation
Miffyli
approved these changes
Apr 11, 2022
Miffyli
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, agree with the point. Thanks for cleaning other URLs as well :). Thankfully PyTorch has been 95% backwards compatible in this regard.
My biggest worry is that saved models might not work as intended (or something small has changed there), but indeed, people can install other PyTorch version for this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump PyTorch version to be able to use the latest features (will be needed for Stable-Baselines-Team/stable-baselines3-contrib#62 for the covariance matrix), newest version also introduces bug fixes and performance improvements.
In practice, SB3 should still be usable with many PyTorch versions though.
Updated doc to link to Gym official doc website.
Motivation and Context
Types of changes
closes #813
Checklist:
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line